Skip to content

WOR-1491: make workflows_bindings_rpc obsolete - #6987

Merged
Caio-Nogueira merged 1 commit into
mainfrom
WOR-1491
Aug 20, 2026
Merged

WOR-1491: make workflows_bindings_rpc obsolete#6987
Caio-Nogueira merged 1 commit into
mainfrom
WOR-1491

Conversation

@Caio-Nogueira

Copy link
Copy Markdown
Contributor

WOR-1537 added a compatibility-gate bypass for private inner fetchers when constructing wrapped bindings. This allows Workflow bindings on old compatibility dates to resolve their JSRPC methods.

@Caio-Nogueira
Caio-Nogueira requested review from a team as code owners August 13, 2026 11:22
@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

UnknownError: Failed to initialize provider: cloudflare-ai-gateway

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@Caio-Nogueira Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq

codspeed-hq Bot commented Aug 13, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.04%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
JsString_Utf8Length_Utf16_Invalid_NonFlat_256 9.5 µs 10.7 µs -11.33%
request[RegExpBenchmark] 4.1 ms 4.5 ms -8.73%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing WOR-1491 (aeb83ff) with main (de2058f)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@pombosilva

Copy link
Copy Markdown
Contributor

/bonk

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@Caio-Nogueira
Caio-Nogueira force-pushed the WOR-1491 branch 4 times, most recently from 4e6c0ce to 7a6d47c Compare August 20, 2026 16:07
WOR-1537 added a compatibility-gate bypass for private inner
fetchers when constructing wrapped bindings. This allows Workflow
bindings on old compatibility dates to resolve their JSRPC methods.

Use JSRPC unconditionally and remove the legacy HTTP transport. Keep
the workflows_bindings_rpc flag name for configuration validation,
but make it a no-op. Cover old dates in workerd and edgeworker tests.
@Caio-Nogueira
Caio-Nogueira merged commit c74dfdf into main Aug 20, 2026
23 of 24 checks passed
@Caio-Nogueira
Caio-Nogueira deleted the WOR-1491 branch August 20, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants